-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canal v3.3.0 for Kubernetes v1.12+ #6037
Conversation
Notes:
https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/ |
603ca51
to
1f68d51
Compare
I'm gonna do some more testing on this first, will update when completed. |
1f68d51
to
1ada8a9
Compare
/retest |
Tested and appears to have applied fine, when the pods are scheduled their spec includes: priority: 2000001000
priorityClassName: system-node-critical Removing the WIP tag, ready for review. :) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gambol99, KashifSaadat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kops-e2e-kubernetes-aws |
Changes:
"Kubernetes 1.12 includes alpha Stream Control Transmission Protocol (SCTP) support. Calico v3.3 supports SCTP in Kubernetes network policies."
priorityClassName
tosystem-node-critical
, as the previous critical-pod annotation is deprecated and will soon be removed: https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/