Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canal v3.3.0 for Kubernetes v1.12+ #6037

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

KashifSaadat
Copy link
Contributor

@KashifSaadat KashifSaadat commented Nov 2, 2018

Changes:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@KashifSaadat
Copy link
Contributor Author

KashifSaadat commented Nov 2, 2018

Notes:

  • The PodPriority Class system-node-critical already exists and so has been reused for the Canal DS Spec.
  • Pod Priority & Preemption is enabled by default from Kubernetes v1.11 and onwards. If it's disabled then the field seems to get ignored and dropped from the manifest.

https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/

@KashifSaadat KashifSaadat changed the title Canal v3.3.0 for Kubernetes v1.12+ WIP: Canal v3.3.0 for Kubernetes v1.12+ Nov 2, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2018
@KashifSaadat
Copy link
Contributor Author

I'm gonna do some more testing on this first, will update when completed.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2018
@KashifSaadat
Copy link
Contributor Author

/retest

@KashifSaadat
Copy link
Contributor Author

Tested and appears to have applied fine, when the pods are scheduled their spec includes:

  priority: 2000001000
  priorityClassName: system-node-critical

Removing the WIP tag, ready for review. :)

@KashifSaadat KashifSaadat changed the title WIP: Canal v3.3.0 for Kubernetes v1.12+ Canal v3.3.0 for Kubernetes v1.12+ Nov 5, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2018
@gambol99
Copy link
Contributor

gambol99 commented Nov 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gambol99, KashifSaadat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KashifSaadat,gambol99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KashifSaadat
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit 637fac9 into kubernetes:master Nov 5, 2018
@KashifSaadat KashifSaadat deleted the canal-v3.3 branch November 5, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants