Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "if" -> "if and only if" to make more clear #6041

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

mooncak
Copy link
Contributor

@mooncak mooncak commented Nov 4, 2018

Change "if" -> "if and only if" to make it more clear

Signed-off-by: mooncake <xcoder@tenxcloud.com>
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 4, 2018
@mooncak
Copy link
Contributor Author

mooncak commented Nov 4, 2018

/assign @chrislovecnm

@justinsb
Copy link
Member

justinsb commented Nov 4, 2018

Ah - this is "iff" in the sense of "if and only if" https://en.wikipedia.org/wiki/If_and_only_if#Origin_of_iff_and_pronunciation

I agree that's pretty obscure though, so if you wanted to do if -> if and only if that would be clearer :-)

@justinsb justinsb assigned justinsb and unassigned chrislovecnm Nov 4, 2018
@mooncak
Copy link
Contributor Author

mooncak commented Nov 5, 2018

Ah - this is "iff" in the sense of "if and only if" https://en.wikipedia.org/wiki/If_and_only_if#Origin_of_iff_and_pronunciation

I agree that's pretty obscure though, so if you wanted to do if -> if and only if that would be clearer :-)

Done

@mooncak mooncak changed the title Fix typos: iff -> if Change "if" -> "if and only if" to make more clear Nov 5, 2018
@mikesplain
Copy link
Contributor

Thanks @mooncak!
/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, mooncak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8aa61bc into kubernetes:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants