Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos #6048

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Fix some typos #6048

merged 1 commit into from
Nov 10, 2018

Conversation

mooncak
Copy link
Contributor

@mooncak mooncak commented Nov 6, 2018

Fix some typos in below files:

  1. cmd/kops/toolbox_template.go
  2. node-authorizer/pkg/server/types.go
  3. node-authorizer/pkg/utils/logger.go

Signed-off-by: mooncake <xcoder@tenxcloud.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @mooncak. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2018
@mooncak
Copy link
Contributor Author

mooncak commented Nov 6, 2018

/assign @gambol99

@mooncak
Copy link
Contributor Author

mooncak commented Nov 8, 2018

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@mooncak: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justinsb
Copy link
Member

justinsb commented Nov 9, 2018

Thanks @mooncak

/approve
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mooncak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2018
@mooncak
Copy link
Contributor Author

mooncak commented Nov 9, 2018

/test pull-kops-e2e-kubernetes-aws

@mooncak
Copy link
Contributor Author

mooncak commented Nov 9, 2018

/retest

1 similar comment
@mooncak
Copy link
Contributor Author

mooncak commented Nov 9, 2018

/retest

@mooncak
Copy link
Contributor Author

mooncak commented Nov 10, 2018

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit 2e9690d into kubernetes:master Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants