Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a dateformat on logrotate configs on CoreOS #6059

Merged
merged 1 commit into from
Nov 24, 2018

Conversation

ripta
Copy link
Contributor

@ripta ripta commented Nov 8, 2018

Closes #5378.

On CoreOS Container Linux, /usr/share/logrotate/logrotate.conf (which is on a read-only mount) enables dateext, which causes maxsize-based log rotation to fail when a previous rotation already happened on the calendar same day. This has the undesirable effect that kube-system logs in /var/log grow unbounded until it dominates and fills up /.

On CoreOS Container Linux, `dateext` is set, which causes log rotation
based on maxsize to not run, when a previous rotation already happened
on the calendar same day.

(cherry picked from commit 585d0a0)
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @ripta. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 8, 2018
@ripta
Copy link
Contributor Author

ripta commented Nov 8, 2018

/assign @chrislovecnm

Ready for review.

@chrisz100
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2018
@justinsb
Copy link
Member

Thanks @ripta - I also appreciate it being a focused fix, as it makes it easier to apply at this stage in the cycle, even if we'll likely want to broaden it in future.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, ripta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4eeba15 into kubernetes:master Nov 24, 2018
@ripta ripta deleted the coreos-logrotate branch November 25, 2018 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants