autoscaler setup: Use set -e to stop execution if errors are encountered

[eherot]

I think this is especially important in this script because variables that are set incorrectly can easily add unwanted resources to the cluster, or add it to the wrong cluster!

[k8s-ci-robot]

Hi @eherot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[justinsb]

Good idea @eherot

We probably should use our normal "strict mode" https://github.com/kubernetes/kubernetes/blob/7f23a743e8c23ac6489340bbb34fa6f1d392db9d/build/copy-output.sh#L18-L20 but I don't think it matters here (pipefail is the one that always surprises me though!)

/approve
/lgtm
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eherot, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eherot]

Good suggestions! I'll definitely keep those in mind in the future.