Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a1 and c5n instance types #6117

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Add a1 and c5n instance types #6117

merged 1 commit into from
Nov 27, 2018

Conversation

justinsb
Copy link
Member

  • Updated vpc_ip_resource_limits
  • Ran make update-machine-types

@justinsb
Add a1 and c5n instance types
9a8100f 
* Updated vpc_ip_resource_limits
* Ran `make update-machine-types`
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 27, 2018
@mikesplain
Copy link
Contributor

Thanks @justinsb!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Member Author

Thanks for writing the generator which makes this easy @mikesplain :-)

Looks like a lack of machines in ca-central-1...

/retest

@k8s-ci-robot k8s-ci-robot merged commit f57d836 into kubernetes:master Nov 27, 2018
@tuananh
Copy link

tuananh commented Nov 27, 2018

@justinsb sorry im just curious. why are the ECU all zeros? Is it not used?

@justinsb justinsb mentioned this pull request Dec 21, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 21, 2018
@k8s-ci-robot
Merge pull request #6249 from justinsb/cherrypick_6117_release-1.11
57ffd19 
Cherry pick of #6117 onto release-1.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @mikesplain @k8s-ci-robot @tuananh