ExperimentalAllowedUnsafeSysctls has moved to AllowedUnsafeSysctls in k8s 1.11 #6179
Conversation
k8s-ci-robot
added
cncf-cla: yes
| if kubeletConfig.ExperimentalAllowedUnsafeSysctls != nil { | ||
| // The ExperimentalAllowedUnsafeSysctls flag was renamed in k/k #63717 | ||
| if b.IsKubernetesGTE("1.11") { | ||
| glog.V(1).Info("ExperimentalAllowedUnsafeSysctls was renamed in k8s 1.11+, please use AllowedUnsafeSysctls instead.") |
There was a problem hiding this comment.
I like this - it feels like mapping it is the correct thing to do here.
But - it's in nodeup, and most people don't see that.
I'm wondering if we should add this to the configuration generation in kops itself. (It's also better to have less logic in nodeup generally - nodeup is ideally dumb, though in practice there are lots of places where it can't be).
We could have a method which does these flags removed / renamed checks, and remaps / warns / errors as appropriate. In this case remapping seems like the right call, but I think we should actively warn the user, to encourage them to change their configuration
|
Thanks @rdrgmnzs As per my comment, I think we should think about putting this warning somewhere users will see it every time they use kops with the old flag. WDYT? /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@justinsb yeah, I like the idea of having this in Kops instead of nodeup and making the warning more visible. Will work on that and submit a patch. Weird that the bot already landed this. |
Cherry pick of #6179 onto release-1.11
ExperimentalAllowedUnsafeSysctls was promoted to beta and renamed to AllowedUnsafeSysctls in k8s 1.11.
For reference: kubernetes/kubernetes#63717
/assign @justinsb @mikesplain