Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update distroless #6287

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Update distroless #6287

merged 1 commit into from
Jan 4, 2019

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Jan 2, 2019

As otherwise we can't build with bazel 0.21

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2019
@mikesplain
Copy link
Contributor

Ahh yes! I’ve been meaning to do this. Thanks @justinsb!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Update distroless
3ebb7a9 
As otherwise we can't build with bazel 0.21
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2019
@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Jan 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2019
@justinsb
Copy link
Member Author

justinsb commented Jan 4, 2019

Hmmm... looks like a VPC leak maybe? Will look into that separately

/retest

@k8s-ci-robot k8s-ci-robot merged commit 59c1d98 into kubernetes:master Jan 4, 2019
@justinsb justinsb mentioned this pull request Mar 1, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 1, 2019
@k8s-ci-robot
Merge pull request #6560 from justinsb/cherrypick_6287_release-1.11
4124555 
Cherry pick of #6287 onto release-1.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rdrgmnzs rdrgmnzs

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @mikesplain @k8s-ci-robot @rdrgmnzs