Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include docker 18.06.1 missed dependency #6338

Merged
merged 3 commits into from
Jan 17, 2019
Merged

include docker 18.06.1 missed dependency #6338

merged 3 commits into from
Jan 17, 2019

Conversation

nareshku
Copy link
Contributor

@nareshku nareshku commented Jan 14, 2019

Fixes #6225

Thanks to @xrl for doing the actual work.

Testing Completed with docker v17.09.0
Created a cluster on Rhel7 with Calico and deleted

Testing Completed with docker v18.06.1-ce
Created a cluster on Rhel7 with Calico and deleted
Created a cluster on AWS Linux 2 with Amazon VPC CNI and deleted

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 14, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @nareshku. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2019
@nareshku
Copy link
Contributor Author

/ok-to-test

1 similar comment
@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2019
@bcorijn
Copy link
Contributor

bcorijn commented Jan 15, 2019

@nareshku I would add this for Docker 17.09 as well, since this fails with the same issue.
Only downside I see to this approach is that it fixes the version number. It solves the immediate issue, but it doesn't feel like a very structural fix.

@nareshku
Copy link
Contributor Author

@bcorijn I agree. I have included the dependency for docker v17.09 as well.

@nareshku
Copy link
Contributor Author

@justinsb @mikesplain We have been waiting for docker v18.06 support for sometime, it would be great if you can help us with a release v1.11.1 including this change.

@nareshku
Copy link
Contributor Author

/assign mikesplain

@justinsb
Copy link
Member

I think the locking to a particular version is a concern; mitigating that is that we're locking the docker package anyway. We can at least do something, except that there's no way to express a newer version of container-se because we're currently running off the docker version alone.

I think this gets better with containerd, which isn't too far away now, and will hopefully be packaged more completely.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, nareshku

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 806a4f0 into kubernetes:master Jan 17, 2019
@justinsb
Copy link
Member

Candidate for 1.11.1 I think

@bcorijn
Copy link
Contributor

bcorijn commented Jan 18, 2019

@justinsb Can the PR that adds 18.06 to RHEL and Amazon Linux be cherry-picked as well in that case #6202 ? I believe that didn't make it into 1.11 either.

@justinsb
Copy link
Member

Good point @bcorijn - tagging it also :-)

k8s-ci-robot added a commit that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants