-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include docker 18.06.1 missed dependency #6338
Conversation
container-selinux-2
Hi @nareshku. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
1 similar comment
/ok-to-test |
@nareshku I would add this for Docker 17.09 as well, since this fails with the same issue. |
@bcorijn I agree. I have included the dependency for docker v17.09 as well. |
@justinsb @mikesplain We have been waiting for docker v18.06 support for sometime, it would be great if you can help us with a release v1.11.1 including this change. |
/assign mikesplain |
I think the locking to a particular version is a concern; mitigating that is that we're locking the docker package anyway. We can at least do something, except that there's no way to express a newer version of container-se because we're currently running off the docker version alone. I think this gets better with containerd, which isn't too far away now, and will hopefully be packaged more completely. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, nareshku The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Candidate for 1.11.1 I think |
Good point @bcorijn - tagging it also :-) |
Cherry pick of #6338 onto release-1.11
Fixes #6225
Thanks to @xrl for doing the actual work.
Testing Completed with docker v17.09.0
Created a cluster on Rhel7 with Calico and deleted
Testing Completed with docker v18.06.1-ce
Created a cluster on Rhel7 with Calico and deleted
Created a cluster on AWS Linux 2 with Amazon VPC CNI and deleted