Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Initializers from default admission plugins for 1.12+ #6350

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 16, 2019

Removed from kube-up defaults in 1.12 in kubernetes/kubernetes#66039

The corresponding API group has never been enabled by default, and it does not appear the feature will progress beyond alpha.

@liggitt liggitt changed the title Remove Initializers from default admission plugins Remove Initializers from default admission plugins for 1.12+ Jan 16, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 16, 2019
@liggitt
Copy link
Member Author

liggitt commented Jan 17, 2019

/cc @justinsb

@warmchang
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2019
@rdrgmnzs
Copy link
Contributor

/lgtm

@andrewsykim
Copy link
Member

/approve

This seems fine given Initializers were alpha, to begin with. Either way, I will add to this item to the next kops office hours as a heads up

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 63ba103 into kubernetes:master Jan 17, 2019
@liggitt liggitt deleted the admission-control branch January 25, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants