Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the registry-qps kubelet flag #6357

Merged
merged 2 commits into from
Apr 10, 2019
Merged

add the registry-qps kubelet flag #6357

merged 2 commits into from
Apr 10, 2019

Conversation

sp-joseluis-ledesma
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @sp-joseluis-ledesma. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2019
@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2019
@justinsb justinsb added this to the 1.12 milestone Mar 14, 2019
@maruina
Copy link
Contributor

maruina commented Mar 27, 2019

Hey @sp-joseluis-ledesma, thanks for the PR. We're interested in this as well, would you mind to also add the RegistryBurst flag as well? I appreciate if you don't have time to follow up on this and happy to pick the PR up.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2019
@sp-joseluis-ledesma
Copy link
Contributor Author

I have renamed RegistryQPS to RegistryPullQPS + added RegistryBurst

@sp-joseluis-ledesma
Copy link
Contributor Author

/retest

@maruina
Copy link
Contributor

maruina commented Mar 28, 2019

Thanks a lot!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2019
@sheldonkwok
Copy link

I don't mind forking and rebasing to get the ball rolling again. The qps is way too low by default and we need to up it.

@sp-joseluis-ledesma
Copy link
Contributor Author

sp-joseluis-ledesma commented Apr 10, 2019 •
edited
Loading

Me neither :) but I did that once, and if it is not going to be merged soon we will have to do it again @justinsb , @mikesplain If I do rebase this it will be merged soon ? ^^

EDIT. I just rebased it again ;)

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2019
@mikesplain
Copy link
Contributor

Looks good and looks like Justin's comments were addressed. Thanks @sp-joseluis-ledesma!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, sp-joseluis-ledesma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1ff3414 into kubernetes:master Apr 10, 2019
@granular-ryanbonham granular-ryanbonham mentioned this pull request May 10, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request May 10, 2019
@k8s-ci-robot
Merge pull request #6923 from granular-ryanbonham/cherrypick_6357_rel…
48a5eef 
…ease-1.12

Cherry pick of #6357 onto release-1.12
@ommehaz
Copy link

ommehaz commented Aug 27, 2020

Is registryPullQPS related to this error “pull QPS exceeded”. If it is how to disable it, can a kindly soul explain ? Thanks 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sp-joseluis-ledesma @k8s-ci-robot @mikesplain @maruina @sheldonkwok @ommehaz @justinsb