Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support etcd-manager v3, suitable for backporting #6411

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

justinsb
Copy link
Member

Add etcd-manager v3 in a way that we can safely backport.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 28, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2019
Add etcd-manager v3 in a way that we can safely backport.
@mikesplain
Copy link
Contributor

Thanks for making it backport-able! I think that's a good path forward to migrate people to etcd3!

Thanks!

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ottoyiu
Copy link
Contributor

ottoyiu commented Feb 9, 2019

@justinsb @mikesplain what does it mean to be 'backportable'? it's not abundantly clear what it means from looking at the code. Does that mean that users of kops can fallback to not use etcd-manager?

ie. I can use etcd-manager to upgrade from etcdv2 to etcdv3 and then fallback to directly using etcdv3 using protokube/r53 records?

@zetaab
Copy link
Member

zetaab commented Feb 16, 2019

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit f7048cf into kubernetes:master Feb 16, 2019
justinsb added a commit that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants