Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor names of URLs in assets to clarify their purpose #6420

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Refactor names of URLs in assets to clarify their purpose #6420

merged 1 commit into from
Apr 19, 2019

Conversation

justinsb
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2019
@chrisz100
Copy link
Contributor

This is older then a day, is the
/ok-to-test
necessary for members and even owners now?

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 31, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2019
@justinsb justinsb added this to the 1.13 milestone Mar 15, 2019
@chrisz100
Copy link
Contributor

/approve
/lgtm

Lets get this out of the way too

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4d7df29 into kubernetes:master Apr 19, 2019
This was referenced Apr 23, 2019
Merged
Closed
k8s-ci-robot added a commit that referenced this pull request Apr 23, 2019
@k8s-ci-robot
Merge pull request #6816 from justinsb/cherrypick_6420_release-1.13
174c42d 
Cherry pick of #6420 onto release-1.13
This was referenced May 10, 2019
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request May 14, 2019
@k8s-ci-robot
Merge pull request #6980 from mikesplain/automated-cherry-pick-of-#64…
2a3b0d9 
…20-origin-release-1.14

Automated cherry pick of #6420: Refactor names of URLs in assets to clarify their purpose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chrisz100 chrisz100

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinsb @chrisz100 @k8s-ci-robot