Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Canal manifest to v3.5.0 for k8s v1.12+ #6469

Merged
merged 2 commits into from
Feb 16, 2019

Conversation

KashifSaadat
Copy link
Contributor

@KashifSaadat KashifSaadat commented Feb 14, 2019

Notable Changes:

  • Calico v3.5.0
  • Flannel v0.11.0
  • Calico images are now pulled from Docker Hub rather than Quay
  • The CNI plugin is now installed using a Kubernetes init container rather than a long-lived sidecar
  • You can now provide disableFlannelForwardRules in the Canal networking spec to configure Flannel to not add the default ACCEPT rules to the iptables forward chain (fixes Canal on K8s v1.8 with chain append mode no longer respects networkpolicies #4037)

Calico release notes:

I have kept the roles / bindings resource names in line with previous updates (they are different in the upstream examples provided on the projectcalico website), because during a rolling-upgrade it causes issues where the roleRef cannot be changed without recreating the resource.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KashifSaadat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2019
@KashifSaadat
Copy link
Contributor Author

(BEFORE) Cluster NetworkingSpec:

  networking:
    canal:
      chainInsertMode: append
# iptables -nL FORWARD
Chain FORWARD (policy ACCEPT)
target     prot opt source               destination
KUBE-FORWARD  all  --  0.0.0.0/0            0.0.0.0/0            /* kubernetes forwarding rules */
ACCEPT     all  --  10.10.0.0/16         0.0.0.0/0
ACCEPT     all  --  0.0.0.0/0            10.10.0.0/16
cali-FORWARD  all  --  0.0.0.0/0            0.0.0.0/0            /* cali:wUHhoiAYhphO9Mso */

(AFTER) Cluster NetworkingSpec:

  networking:
    canal:
      chainInsertMode: append
      disableFlannelForwardRules: true
# iptables -nL FORWARD
Chain FORWARD (policy ACCEPT)
target     prot opt source               destination
KUBE-FORWARD  all  --  0.0.0.0/0            0.0.0.0/0            /* kubernetes forwarding rules */
cali-FORWARD  all  --  0.0.0.0/0            0.0.0.0/0            /* cali:wUHhoiAYhphO9Mso */

@KashifSaadat
Copy link
Contributor Author

/assign @gambol99 @justinsb

@chrisz100
Copy link
Contributor

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2019
@KashifSaadat
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit 1d55996 into kubernetes:master Feb 16, 2019
@KashifSaadat KashifSaadat deleted the canal-v3.5 branch February 18, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canal on K8s v1.8 with chain append mode no longer respects networkpolicies
5 participants