Fix elb tagging #6703
Merged
Fix elb tagging #6703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mikesplain
force-pushed
the
fix_elb_tagging
branch
from
4d3a48d
to
7b9166f
Compare
k8s-ci-robot
added
size/L
This comment has been minimized.
This comment has been minimized.
k8s-ci-robot
added
the
do-not-merge/work-in-progress
mikesplain
force-pushed
the
fix_elb_tagging
branch
from
1b72b4b
to
d6c02d3
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @chrisz100 |
chrisz100
approved these changes
Mar 29, 2019
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 29, 2019
…03-origin-release-1.12 Automated cherry pick of #6703: Fix tagging and remove tagging elbs
|
Quick question on the tags. The tagging standards on ELB seem to be more restricted than other services limiting keys/values to be complaint of the pattern "^([\p{L}\p{Z}\p{N}_.:/=+-@]*)$" Would it be a good idea to validate/handle them here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we weren't tagging quite right, also needed to add a removal function.
To note, this also adds a new tag to existing elbs since we're now using
b.Cluster.Spec.CloudLabelsto generate the elb tags:I don't believe this should have any negative effects.
Fixes: #6646, #2048
Since this was included in 1.12 and has some weird effects, I think we should cherry-pick it in.