Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to specify cpuRequest for API Server #6706

Merged
merged 7 commits into from
Apr 10, 2019
Merged

Add ability to specify cpuRequest for API Server #6706

merged 7 commits into from
Apr 10, 2019

Conversation

granular-ryanbonham
Copy link
Contributor

Adds ability to specify cupRequest for the API Server

spec:
  kubeAPIServer:
    cpuRequest: 300m

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 30, 2019
mikesplain
mikesplain reviewed Apr 3, 2019
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of this looks pretty good, just a nit on the comment to make it easier on readers.

pkg/apis/kops/componentconfig.go Outdated Show resolved Hide resolved
@mikesplain
Copy link
Contributor

/assign

@justinsb
Copy link
Member

justinsb commented Apr 7, 2019

This looks good - thanks @granular-ryanbonham . Did you encounter an issue here though? Requests should just be a minimum - they aren't limits; I guess they determine the relative priority though - is that what we're doing here?

@granular-ryanbonham
Copy link
Contributor Author

@justinsb No issues, just hardening the APIServer to ensure that the minimum requested CPU more closely matches the API Servers use so that we do not end up being CPU Starved in CPU usage spikes..

@mikesplain
Copy link
Contributor

Great! Thanks @granular-ryanbonham!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: granular-ryanbonham, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit b91db4f into kubernetes:master Apr 10, 2019
k8s-ci-robot added a commit that referenced this pull request May 10, 2019
@k8s-ci-robot
Merge pull request #6912 from granular-ryanbonham/automated-cherry-pi…
f11b1d8 
…ck-of-#6706-upstream-release-1.12

Automated cherry pick of #6706 upstream release 1.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain left review comments

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@granular-ryanbonham @mikesplain @justinsb @k8s-ci-robot