Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1.3.0 to 1.3.3 #6723

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Conversation

mikesplain
Copy link
Contributor

@mikesplain mikesplain commented Apr 3, 2019

Get things up-to-date for new instance types

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2019
@justinsb
Copy link
Member

justinsb commented Apr 3, 2019

Thanks!

I think we should still bump the version in bootstrapchannelbuilder, even though this is a weird case (and I'm not sure we handle updates to image overrides correctly generally)

Also, do you think we want this in 1.12 or can it wait till 1.13?

@mikesplain mikesplain modified the milestone: 1.12 Apr 3, 2019
@mikesplain
Copy link
Contributor Author

Oh yeah good eye @justinsb, I'll bump that as well. I'd like to see it in 1.12 but it certainly shouldn't hold up the release.

@granular-ryanbonham
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2019
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chrislovecnm,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikesplain
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0d75160 into kubernetes:master Apr 5, 2019
k8s-ci-robot added a commit that referenced this pull request Apr 5, 2019
…23-origin-release-1.12

Automated cherry pick of #6723: Update 1.3.0 to 1.3.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants