-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 1.3.0 to 1.3.3 #6723
Update 1.3.0 to 1.3.3 #6723
Conversation
Thanks! I think we should still bump the version in bootstrapchannelbuilder, even though this is a weird case (and I'm not sure we handle updates to image overrides correctly generally) Also, do you think we want this in 1.12 or can it wait till 1.13? |
Oh yeah good eye @justinsb, I'll bump that as well. I'd like to see it in 1.12 but it certainly shouldn't hold up the release. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
…23-origin-release-1.12 Automated cherry pick of #6723: Update 1.3.0 to 1.3.3
Get things up-to-date for new instance types