Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use version number as well as name when checking LaunchTemplates #6753

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Use version number as well as name when checking LaunchTemplates #6753

merged 1 commit into from
Apr 8, 2019

Conversation

granular-ryanbonham
Copy link
Contributor

Use LaunchTemplateName and Version when calculation if LaunchTemplate has changed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2019
@granular-ryanbonham
Copy link
Contributor Author

Fixes #6751

@granular-ryanbonham granular-ryanbonham changed the title User version number as well as name when checking LaunchTemplates Use version number as well as name when checking LaunchTemplates Apr 8, 2019
@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Apr 8, 2019

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 8, 2019
@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Apr 8, 2019

/assign @gambol99 @justinsb

@mikesplain
Copy link
Contributor

Thanks @granular-ryanbonham!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: granular-ryanbonham, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2019
@mikesplain mikesplain mentioned this pull request Apr 8, 2019
Merged
@k8s-ci-robot k8s-ci-robot merged commit d1fc04d into kubernetes:master Apr 8, 2019
k8s-ci-robot added a commit that referenced this pull request Apr 9, 2019
@k8s-ci-robot
Merge pull request #6755 from mikesplain/automated-cherry-pick-of-#67…
f5c8757 
…53-origin-release-1.12

Automated cherry pick of #6753: User version number as well as name when checking
@justinsb justinsb mentioned this pull request Apr 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@rdrgmnzs rdrgmnzs

@mikesplain mikesplain

@gambol99 gambol99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@granular-ryanbonham @rdrgmnzs @mikesplain @k8s-ci-robot @justinsb @gambol99