Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in aws-iam-authenticator image field name #6840

Merged

Conversation

rifelpet
Copy link
Member

Introduced here: https://github.com/kubernetes/kops/pull/6730/files#diff-843e01eb04cf09979da2bd7a655b3526R280

This typo hasn't been in any stable Kops releases, so backwards compatibility shouldn't be necessary.

This will need to be backported to release-1.14 and release-1.13

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2019
@rifelpet
Copy link
Member Author

/area api

@mikesplain
Copy link
Contributor

Thanks @rifelpet

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
k8s-ci-robot added a commit that referenced this pull request Apr 26, 2019
…-origin-release-1.14

Automated cherry pick of #6840: Fix typo in aws-iam-authenticator image field name
k8s-ci-robot added a commit that referenced this pull request Apr 26, 2019
…-origin-release-1.13

Automated cherry pick of #6840: Fix typo in aws-iam-authenticator image field name
@k8s-ci-robot k8s-ci-robot merged commit 0709200 into kubernetes:master Apr 26, 2019
k8s-ci-robot added a commit that referenced this pull request May 10, 2019
@rifelpet rifelpet deleted the aws-iam-authenticator-api-typo branch August 6, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants