Add usesNAT flag to control nonMasqueradeCIDR check for custom CNI networking

[adammw]

Add usesNAT flag to control nonMasqueradeCIDR check for custom CNI networking.

Previously, only the kops-controlled amazonvpc or lyftvpc addons were allowed to overlap the nonMasqueradeCIDR with the network CIDR. This allows overlap with a custom CNI plugin, unless the user declares that the plugin uses NAT (and therefore the CIDRs should not overlap).

/cc @grosser

[k8s-ci-robot]

@adammw: GitHub didn't allow me to request PR reviews from the following users: grosser.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Add usesNAT flag to control nonMasqueradeCIDR check for custom CNI networking.

Previously, only the kops-controlled amazonvpc or lyftvpc addons were allowed to overlap the nonMasqueradeCIDR with the network CIDR. This allows overlap with a custom CNI plugin, unless the user declares that the plugin uses NAT (and therefore the CIDRs should not overlap).

/cc @grosser

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @adammw. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adammw
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mikesplain

If they are not already assigned, you can assign the PR to them by writing /assign @mikesplain in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adammw]

/assign @mikesplain
/cc @justinsb @rdrgmnzs

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.