S3 VFS: Default to current region from metadata service #6943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a region to start from to make AWS calls. us-east-1 works for most credentials, but not for cn-north-1 credentials. Instead, we get the current region from metadata when running on EC2; and we continue to fall-back to us-east-1. For CLI commands (kops) the user will still have to set AWS_REGION, but for system binaries (nodeup, etcd-manager), this should default appropriately. Note that the region doesn't have to be the actual region of the bucket, just a region we can access. Issue kubernetes#6098
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced May 13, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
May 13, 2019
…ease-1.12 Cherry pick of #6943 onto release-1.12
k8s-ci-robot
added a commit
that referenced
this pull request
May 15, 2019
…ease-1.13 Cherry pick of #6943 onto release-1.13
k8s-ci-robot
added a commit
that referenced
this pull request
May 15, 2019
…ease-1.14 Cherry pick of #6943 onto release-1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a region to start from to make AWS calls. us-east-1 works for
most credentials, but not for cn-north-1 credentials. Instead, we get
the current region from metadata when running on EC2; and we continue
to fall-back to us-east-1.
For CLI commands (kops) the user will still have to set AWS_REGION,
but for system binaries (nodeup, etcd-manager), this should default
appropriately.
Note that the region doesn't have to be the actual region of the
bucket, just a region we can access.
Issue #6098