Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker not being installed on Ubuntu 16.04 #6965

Merged

Conversation

mfrister
Copy link
Contributor

kops 1.12 uses a new Docker version by default (18.06.3), which nodeup has no package for on Ubuntu 16.04. This results in Docker not being installed when using 1.12-beta.2.

Fixes #6585.

This MR is against master - it probably makes sense to cherry-pick this into the release-1.12 branch (and possibly others).

Tested with a custom nodeup build on the release-1.12 branch.

This only affects the default Docker version for 1.12 (18.06.3).
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @meeee. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 14, 2019
@justinsb
Copy link
Member

/ok-to-test
/approve
/lgtm

Thanks for spotting, reporting & fixing @meeee :-)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, meeee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2019
@justinsb
Copy link
Member

/test pull-kops-verify-bazel

Looks like a test-infra flake - can't open logs

@k8s-ci-robot k8s-ci-robot merged commit 539f84c into kubernetes:master May 14, 2019
@mfrister mfrister deleted the ubuntu-16.04-fix-docker-install branch May 14, 2019 11:10
k8s-ci-robot added a commit that referenced this pull request May 14, 2019
k8s-ci-robot added a commit that referenced this pull request May 14, 2019
k8s-ci-robot added a commit that referenced this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodeup: Did not find docker package for xenial amd64 18.06.3
3 participants