Mark ENI 0 as delete_on_termination for LaunchTemplates #7094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, which will run accounts our of ENIs.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/S
granular-ryanbonham
changed the title
|
This should be CP to 1.12, 1.13, 1.14 |
granular-ryanbonham
changed the title
|
Wow, that's terrible. Great find @granular-ryanbonham! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: granular-ryanbonham, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kops-e2e-kubernetes-aws |
This was referenced Jun 5, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 5, 2019
…ease-1.12 Cherry pick of #7094 onto release-1.12
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 5, 2019
…ease-1.13 Cherry pick of #7094 onto release-1.13
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 5, 2019
…ease-1.14 Cherry pick of #7094 onto release-1.14
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not setting the primary eni has delete_on_termination when using LaunchTemplates, which is leaving behind ENIs