-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to set the --kube-api-qps and --kube-api-burst flags on KubeControllerManager #7153
Conversation
Unrelated test timed out. /test pull-kops-e2e-kubernetes-aws |
/test pull-kops-e2e-kubernetes-aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tests have been supper flaky, will try to take a look at them later tonight. /test pull-kops-e2e-kubernetes-aws |
Cross-checked against the upstream types / names - looks good! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Cherry pick of #7153 onto release-1.14
Cherry pick of #7153 onto release 1.13
This only adds the flags to Kops, it does not set the value on controller manager. If the flags is not specified it is omitted from the controller managers config and uses the default value.