Warn/prevent if the version of etcd is unsupported with etcd-manager #7340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should prevent the scenario where etcd-manager can't come up because of a different version. Can be bypassed with the SkipEtcdVersionCheck feature flag.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
mikesplain
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
Oh this looks great. Very useful! Thanks @justinsb!
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Aug 1, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 1, 2019
Cherry pick of #7340 onto release-1.13
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 1, 2019
Cherry pick of #7340 onto release-1.14
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 1, 2019
Cherry pick of #7340 onto release-1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent the scenario where etcd-manager can't come up because of a different version.
Can be bypassed with the SkipEtcdVersionCheck feature flag.