-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CapacityOptimized to list of supported spot allocation strategies #7406
Add CapacityOptimized to list of supported spot allocation strategies #7406
Conversation
Hi @gjtempleton. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gjtempleton @robinpercy Cheers, it would be really cool if this feature would land in a near future release. Any help needed still to make progress? |
I was initially held up by being unsure whether I needed to wait for terraform to support it as well as CloudFormation. We discussed it at Office Hours yesterday and found a solution for now, will get this in shape by the end of this weekend. Thanks for the offer @hrzbrg. |
a0e999f
to
c98d9f0
Compare
0ee53e0
to
eff0683
Compare
Add Terraform capacity-optimised warning s/optimised/optimized/
eff0683
to
f6218a5
Compare
Now ready for review and tested locally. Only area I'm unsure on is whether the Terraform warning is in the right place. |
/assign @KashifSaadat |
/ok-to-test |
Thanks for the contribution! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, KashifSaadat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…406-upstream-release-1.16 Automated cherry pick of #7406: Add CapacityOptimized to list of supported spot allocation
…406-upstream-release-1.17 Automated cherry pick of #7406: Add CapacityOptimized to list of supported spot allocation
Adds the new CapacityOptimized spot allocation strategy to the list of supported spot allocation strategies. More info about the new allocation strategy found here: https://aws.amazon.com/blogs/compute/introducing-the-capacity-optimized-allocation-strategy-for-amazon-ec2-spot-instances/
Marking as WIP until the merging of #7404 and hashicorp/terraform-provider-aws#9750 as I've not had the chance to test it yet and Terraform will need to support it first.
EDIT: Discussed at Office Hours on the 8th of November and decided Terraform support is no longer a blocker for this.
Intended to resolve #7401