Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CapacityOptimized to list of supported spot allocation strategies #7406

Merged

Conversation

gjtempleton
Copy link
Member

@gjtempleton gjtempleton commented Aug 14, 2019

Adds the new CapacityOptimized spot allocation strategy to the list of supported spot allocation strategies. More info about the new allocation strategy found here: https://aws.amazon.com/blogs/compute/introducing-the-capacity-optimized-allocation-strategy-for-amazon-ec2-spot-instances/

Marking as WIP until the merging of #7404 and hashicorp/terraform-provider-aws#9750 as I've not had the chance to test it yet and Terraform will need to support it first.

EDIT: Discussed at Office Hours on the 8th of November and decided Terraform support is no longer a blocker for this.

Intended to resolve #7401

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @gjtempleton. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 14, 2019
@hrzbrg
Copy link

hrzbrg commented Nov 9, 2019

@gjtempleton @robinpercy Cheers, it would be really cool if this feature would land in a near future release. Any help needed still to make progress?

@gjtempleton
Copy link
Member Author

I was initially held up by being unsure whether I needed to wait for terraform to support it as well as CloudFormation. We discussed it at Office Hours yesterday and found a solution for now, will get this in shape by the end of this weekend.

Thanks for the offer @hrzbrg.

@gjtempleton gjtempleton force-pushed the Capacity-Optimized-Spot-Strategy branch from a0e999f to c98d9f0 Compare November 9, 2019 16:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2019
@gjtempleton gjtempleton force-pushed the Capacity-Optimized-Spot-Strategy branch from 0ee53e0 to eff0683 Compare November 9, 2019 18:18
@gjtempleton gjtempleton changed the title WIP - Add CapacityOptimized to list of supported spot allocation strategies Add CapacityOptimized to list of supported spot allocation strategies Nov 9, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2019
Add Terraform capacity-optimised warning

s/optimised/optimized/
@gjtempleton gjtempleton force-pushed the Capacity-Optimized-Spot-Strategy branch from eff0683 to f6218a5 Compare November 9, 2019 19:04
@gjtempleton
Copy link
Member Author

gjtempleton commented Nov 9, 2019

Now ready for review and tested locally. Only area I'm unsure on is whether the Terraform warning is in the right place.

@gjtempleton
Copy link
Member Author

/assign @KashifSaadat

@gjtempleton
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2019
@KashifSaadat
Copy link
Contributor

Thanks for the contribution!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, KashifSaadat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8fead73 into kubernetes:master Dec 3, 2019
@gjtempleton gjtempleton deleted the Capacity-Optimized-Spot-Strategy branch December 3, 2019 10:52
k8s-ci-robot added a commit that referenced this pull request Dec 17, 2019
…406-upstream-release-1.16

Automated cherry pick of #7406: Add CapacityOptimized to list of supported spot allocation
k8s-ci-robot added a commit that referenced this pull request Dec 17, 2019
…406-upstream-release-1.17

Automated cherry pick of #7406: Add CapacityOptimized to list of supported spot allocation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Capacity-Optimized Spot Instance Allocation Strategy
4 participants