Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing audit dynamic configuration (#7392) #7424

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Implementing audit dynamic configuration (#7392) #7424

merged 1 commit into from
Nov 26, 2019

Conversation

mmerrill3
Copy link
Contributor

Signed-off-by: mmerrill3 michael.merrill@vonage.com

This addresses issue #7392 to allow for dynamic audit configuration, so tools like falco can easily be integrated with kops to ingest audit logs through audit sinks.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mmerrill3. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2019
@zetaab
Copy link
Member

zetaab commented Aug 16, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 16, 2019
zetaab
zetaab requested changes Aug 16, 2019
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @mmerrill3

Actually I have been thinking to add this feature to our clusters as well. We have already falco running without k8s audit things.

If you can fix that small style thing, its good to go. Also please fix bazel things, one row missing there

nodeup/pkg/model/kube_apiserver.go Outdated
@@ -347,6 +347,13 @@ func (b *KubeAPIServerBuilder) buildPod() (*v1.Pod, error) {
}
}

//remove elements from the spec that are not enabled yet
if b.Cluster.Spec.KubeAPIServer.AuditDynamicConfiguration != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if b.Cluster.Spec.KubeAPIServer.AuditDynamicConfiguration != nil && !b.IsKubernetesGTE("1.13") {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'll push an update after this and rebasing with the upstream master again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated bazel for the test runtime environment and this style update.

@mmerrill3 mmerrill3 force-pushed the feature/dynamic-audit-config branch 3 times, most recently from d343c0e to 6040788 Compare August 16, 2019 15:17
zetaab
zetaab approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @justinsb

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2019
@mmerrill3
Copy link
Contributor Author

rebased with the master branch to get the go mod fix

@mmerrill3
Copy link
Contributor Author

@zetaab I had to rebase to pick up gomod changes. Could you kindly review again?

zetaab
zetaab approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2019
@mmerrill3
Copy link
Contributor Author

I had to rebase again due to api updates in the master around service account parameters. This latest push is a rebase with those changes.

@mmerrill3 mmerrill3 force-pushed the feature/dynamic-audit-config branch 2 times, most recently from b78e391 to 344cc95 Compare October 17, 2019 18:42
@mmerrill3
Copy link
Contributor Author

@justinsb I'll rebase again. Can this be PR be kept in mind next time the API structure for kops is updated again?

Implementing audit dynamic configuration (kubernetes#7392)
5cf94c8 
Signed-off-by: mmerrill3 <michael.merrill@vonage.com>
@mmerrill3 mmerrill3 requested a review from zetaab October 24, 2019 14:55
@palmerabollo
Copy link

@zetaab does it look good to you?

@zetaab
Copy link
Member

zetaab commented Nov 13, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
zetaab
zetaab approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmerrill3, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 482fce5 into kubernetes:master Nov 26, 2019
@mmerrill3 mmerrill3 deleted the feature/dynamic-audit-config branch December 5, 2019 19:06
@zetaab
Copy link
Member

zetaab commented Dec 5, 2019

@mmerrill3 could you please cherry-pick this to release-1.17?

@KashifSaadat
Copy link
Contributor

I've cherry-picked to 1.16 (#8679) & 1.17 (#8678)

k8s-ci-robot added a commit that referenced this pull request Mar 5, 2020
@k8s-ci-robot
Merge pull request #8679 from appvia/automated-cherry-pick-of-#7424-o…
dfc87bc 
…rigin-release-1.16

Automated cherry pick of #7424: Implementing audit dynamic configuration (#7392)
k8s-ci-robot added a commit that referenced this pull request Mar 5, 2020
@k8s-ci-robot
Merge pull request #8678 from appvia/automated-cherry-pick-of-#7424-o…
867ebcb 
…rigin-release-1.17

Automated cherry pick of #7424: Implementing audit dynamic configuration (#7392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mmerrill3 @k8s-ci-robot @zetaab @palmerabollo @KashifSaadat @justinsb