Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] Update to golang 1.11.13 #7549

Merged

Conversation

justinsb
Copy link
Member

Similar to #7499, we particularly want the http fixes:

https://golang.org/doc/devel/release.html#go1.11.minor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 10, 2019
@justinsb justinsb changed the title Update to golang 1.11.13 [release-1.13] Update to golang 1.11.13 Sep 10, 2019
@justinsb
Copy link
Member Author

Note: targeting release-1.13 branch

@rifelpet
Copy link
Member

Does the Makefile need to get updated as well?

https://github.com/kubernetes/kops/blob/release-1.13/Makefile#L24

Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2db059c into kubernetes:release-1.13 Sep 10, 2019
justinsb added a commit to justinsb/kops that referenced this pull request Sep 10, 2019
Adding a few places I missed in kubernetes#7549

Thanks @rifelpet for the heads-up!
justinsb added a commit to justinsb/kops that referenced this pull request Sep 10, 2019
Adding a few places I missed in kubernetes#7549

Thanks @rifelpet for the heads-up!
@justinsb
Copy link
Member Author

Quite right @rifelpet - added in #7552

justinsb added a commit to justinsb/kops that referenced this pull request Sep 10, 2019
Adding a few places I missed in kubernetes#7549

Thanks rifelpet for the heads-up!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants