Check the HTTP response code when downloading URLs #7611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the recent container-selinux issue on centos was reporting a hash mismatch rather than a 404. See the error message here: kubernetes#7608 and the "actual" sha1 response is that of the 404 page: ``` curl http://mirror.centos.org/centos/7/extras/x86_64/Packages/container-selinux-2.68-1.el7.noarch.rpm curl http://mirror.centos.org/centos/7/extras/x86_64/Packages/container-selinux-2.68-1.el7.noarch.rpm | shasum -a 1 ```
k8s-ci-robot
added
cncf-cla: yes
mikesplain
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
Great idea. Thanks for the quick fix @rifelpet!
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kops-e2e-kubernetes-aws |
|
/retest |
This was referenced Sep 18, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 18, 2019
…11-origin-release-1.13 Automated cherry pick of #7611: Check the HTTP response code when downloading URLs
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 18, 2019
…11-origin-release-1.15 Automated cherry pick of #7611: Check the HTTP response code when downloading URLs
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 18, 2019
…11-origin-release-1.14 Automated cherry pick of #7611: Check the HTTP response code when downloading URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the recent container-selinux issue on centos was reporting a hash mismatch rather than a 404.
See the error message here: #7608 and the "actual" sha1 reported in the current error message is that of the 404 page:
This should now report a more descriptive error message if this happens again.