Calico: upgrade pod2daemon (only) #7689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per docs/development/instancesizes.md we don't have much cpu on a 1 core machine. Note that this is only requests, not limits, so calico can still burst. At least related to issue kubernetes#7592
We want to pick up projectcalico/pod2daemon#28 , to address kubernetes#7592 . This is not ideal, but looking at the commit changes the only potentially problematic change in the diff is projectcalico/pod2daemon#21 , which seems like it shouldn't cause ay skew issues.
k8s-ci-robot
added
cncf-cla: yes
|
Torn on whether to do this for 1.14.0 - it should clean up the log problems, but it is potentially risky. I'm leaning towards doing it, because the log problems show up in kube-controller-manager logs |
|
Thanks @justinsb! Seems like worth while for now to at least get this merged in master. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I'm going to do some testing on this now to see if I notice any issues with it on 1.14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to pick up projectcalico/pod2daemon#28 , to
address #7592 .
This is not ideal, but looking at the commit changes the only potentially
problematic change in the diff is
projectcalico/pod2daemon#21 , which seems like it
shouldn't cause ay skew issues.