Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom sysctl Parameters #7730

Merged
merged 4 commits into from
Jan 3, 2020
Merged

Conversation

ripta
Copy link
Contributor

@ripta ripta commented Oct 2, 2019

This adds a new sysctlParameters to cluster spec and instance group spec to allow setting custom runtime kernel parameters.

I needed to be able to set sysctl parameters on our nodes. I considered adding a file asset, but we can't currently set the OnChangeExecute of a File nodetask that way. Since we already have a sysctl builder, this change seemed to be an obvious one.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @ripta. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2019
@ripta
Copy link
Contributor Author

ripta commented Oct 2, 2019

/assign @gambol9

@k8s-ci-robot
Copy link
Contributor

@ripta: GitHub didn't allow me to assign the following users: gambol9.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gambol9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ripta
Copy link
Contributor Author

ripta commented Oct 2, 2019

Oops. Would've been nice to not typo.

/assign @gambol99

Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2019
@ripta
Copy link
Contributor Author

ripta commented Oct 30, 2019

/retest

@ripta
Copy link
Contributor Author

ripta commented Nov 5, 2019

@justinsb @mikesplain - Could I get a review? Also, looks like pull-kops-e2e-kubernetes-aws is currently broken, unrelated to this change.

@mikesplain
Copy link
Contributor

/retest

@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Dec 4, 2019

Hi @ripta I just went over the PR and things are looking pretty good. Could you please add documentation for it before we go ahead and merge it.

@ripta
Copy link
Contributor Author

ripta commented Dec 5, 2019

@rdrgmnzs - I added a section on sysctlParameters on both the cluster spec and instance group spec pages. Let me know what you think!

@johngmyers
Copy link
Member

/test pull-kops-verify-staticcheck

@mikesplain
Copy link
Contributor

This looks great. Thanks @ripta!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, ripta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2020
@rifelpet
Copy link
Member

rifelpet commented Jan 3, 2020

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit afb4ecb into kubernetes:master Jan 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 3, 2020
k8s-ci-robot added a commit that referenced this pull request Feb 25, 2020
…pstream-release-1.17

Automated cherry pick of #7730: Add SysctlParameters to ClusterSpec and InstanceGroupSpec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants