Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct expression typos on docs/aws.md #7733

Merged
merged 2 commits into from
May 1, 2020

Conversation

gpontesss
Copy link
Contributor

@gpontesss gpontesss commented Oct 2, 2019

Correct expression typos and enhance text on docs/aws.md.

Note: This is my first contribution to an open source project. I will appreciate suggestions and directions on what to do/not to do.

@k8s-ci-robot
Copy link
Contributor

Welcome @gpontesss!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @gpontesss. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2019
@gpontesss
Copy link
Contributor Author

I did sign the CNCF CLA.

i think I'm supposed to it, also:
/assign @justinsb

@gpontesss
Copy link
Contributor Author

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Replying.

@mikesplain
Copy link
Contributor

Thanks for this @gpontesss. Before we can kick off tests we need to ensure the CLA is setup properly.

/check-cla

@mikesplain
Copy link
Contributor

Can you confirm you've followed these steps, the CLA is linked to this github account as well as the email address used to commit these commits? Otherwise please reach out to the CNCF's help desk. Thanks!

Note, you only have to do this once to get access to all CNCF/Kubernetes projects!

@gpontesss
Copy link
Contributor Author

Can you confirm you've followed these steps, the CLA is linked to this github account as well as the email address used to commit these commits?

I did as described. I also checked the commit email and the email registered on the CLA. I'll try again.

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 3, 2019
@justinsb
Copy link
Member

justinsb commented Nov 7, 2019

Thanks and sorry for the CLA bot problems and then my delay in reviewing!

/approve
/lgtm
/ok-to-test

Would you mind rebasing - I can't resolve the conflict it looks like...

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gpontesss, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@justinsb justinsb added this to the 1.17 milestone Nov 8, 2019
@rifelpet
Copy link
Member

@gpontesss if you can rebase and fix the conflicts, we can get this merged soon

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2019
@rifelpet rifelpet removed this from the v1.17 milestone Jan 30, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2020
Correct expression typos and enhance text on `docs/aws.md`.
@k8s-ci-robot k8s-ci-robot added area/documentation and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 1, 2020
docs/getting_started/aws.md Outdated Show resolved Hide resolved
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
@rifelpet
Copy link
Member

rifelpet commented May 1, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit b475d0b into kubernetes:master May 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants