Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PodDisruptionBudget for kube-dns in kube-system namespace #7856

Merged
merged 2 commits into from Nov 17, 2019
Merged

Create PodDisruptionBudget for kube-dns in kube-system namespace #7856

merged 2 commits into from Nov 17, 2019

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 30, 2019

Fixes #7855

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @hakman!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @hakman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2019
@hakman
Copy link
Member Author

hakman commented Oct 30, 2019

/assign @mikesplain

@zetaab
Copy link
Member

zetaab commented Oct 30, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2019
@hakman
Copy link
Member Author

hakman commented Oct 30, 2019

/test pull-kops-bazel-test

@hakman
Copy link
Member Author

hakman commented Oct 30, 2019

/test pull-kops-e2e-kubernetes-aws

1 similar comment
@hakman
Copy link
Member Author

hakman commented Oct 31, 2019

/test pull-kops-e2e-kubernetes-aws

@bittopaz
Copy link
Contributor

The test seems broken...

@hakman
Copy link
Member Author

hakman commented Oct 31, 2019

The test seems broken...

I guess waiting a bit won't hurt.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2019
@hakman
Copy link
Member Author

hakman commented Nov 4, 2019

/test pull-kops-e2e-kubernetes-aws

@hakman
Copy link
Member Author

hakman commented Nov 6, 2019

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 6, 2019
@rifelpet
Copy link
Member

rifelpet commented Nov 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2019
mikesplain
mikesplain approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Thanks for fixing and for the contribution!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2019
k8s-ci-robot added a commit that referenced this pull request Nov 17, 2019
@k8s-ci-robot
Merge pull request #7856 from hakman/master
5c88ee4 
Create PodDisruptionBudget for kube-dns in kube-system namespace
@k8s-ci-robot k8s-ci-robot merged commit 5c88ee4 into kubernetes:master Nov 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit b069514 into kubernetes:master Nov 17, 2019
@justinsb justinsb mentioned this pull request Nov 18, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 18, 2019
@k8s-ci-robot
Merge pull request #7942 from justinsb/cherrypick_7856_release-1.15
197035e 
Cherry pick of #7856 onto release-1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain approved these changes

@granular-ryanbonham granular-ryanbonham Awaiting requested review from granular-ryanbonham

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@mikesplain mikesplain

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDB for kube-dns is created in the default namespace
6 participants
@hakman @k8s-ci-robot @zetaab @bittopaz @rifelpet @mikesplain