Cleanup make targets #7863
Merged
Cleanup make targets #7863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-kops-e2e-kubernetes-aws |
|
Thanks for cleaning this up @rifelpet /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDFLAGSworkarounds for older (unsupported) versions of gocheck-builds-in-go*targets for more recent versions of go. Since thecitarget requires bazel, rather than trying to install that in a docker container I opted to just use thealltarget which should provide sufficient coverage. Note that the 1.11 target isnt currently working (build k8s.io/cloud-provider: cannot find module for path k8s.io/cloud-provider) I'll need to troubleshoot that more unless we decide to just drop go 1.11 support entirely.make protokubenow respectsEXTRA_BUILDFLAGSdep-ensurecode and updated the prereqs task so thatgomodnow checks for the presence of bazel.