Add verify-gomod and verify-goimports to Travis job

[rifelpet]

It turns out we werent running verify-goimports in any CI job and some files were failing. This adds them in a blocking job which should prevent that from happening again.

[rifelpet]

I'll probably need to vendor goimports the same way we do staticcheck and a few other tools in tools.go

[rifelpet]

Travis is passing and definitely running verify-goimports (see the failing job here) so I think this is ready for review 👍

[geojaz]

@rifelpet Any reason why this should go into travis and not prow? I noticed that we weren't tracking this test while reviewing a patch that was green on prow, but not locally (with make ci). I'd love to see this in prow if possible.

[rifelpet]

No real reason for adding it to Travis vs Prow. We could easily add new prow jobs to test-infra that run each of these two commands, or perhaps collapse all of the verify-* commands into one prow job.

Thoughts?

[geojaz]

I think it probably makes sense to collapse the "linty" stuff verify-* into a single prow job. i will defer to some others who are more recently involved in this space...

[johngmyers]

The advantage of putting it in Travis is that the problems can be detected and fixed before the ok-to-test label is applied. That would save the reviewers some rounds of re-review.

[geojaz]

The advantage of putting it in Travis is that the problems can be detected and fixed before the ok-to-test label is applied. That would save the reviewers some rounds of re-review.

Good point. @rifelpet can you update this and we can get it included?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rifelpet]

@geojaz done!

[geojaz]

/lgtm