Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cilium version to 1.6.4 #8022

Merged
merged 2 commits into from
Dec 8, 2019
Merged

Bump cilium version to 1.6.4 #8022

merged 2 commits into from
Dec 8, 2019

Conversation

olemarkus
Copy link
Member

Most importantly, this fixes a bug in the 1.6.4 branch causing externalTrafficPolicy: local to fail.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 27, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @olemarkus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2019
@zetaab
Copy link
Member

zetaab commented Nov 27, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2019
@brb brb mentioned this pull request Nov 29, 2019
Closed
@aanm aanm mentioned this pull request Dec 5, 2019
Closed
@geojaz
Copy link
Member

geojaz commented Dec 7, 2019

@olemarkus I'm having some trouble getting this to work, however i'm not sure that the problem is with your PR. I'm not that familiar with cilium. Do you have a kops create cluster command that I could give this a run with?

@olemarkus
Copy link
Member Author

Just setting networking to cilium should work. What is it that happens?
There is a known issue of bpf is already mounted, but that shouldn't be the case for current stable AMIs. #7832 will fix that

@geojaz
Copy link
Member

geojaz commented Dec 8, 2019

/lgtm

sorry for the delay. as I suspected, the problem wasn't your PR... :)
i gave this another go today and was able to confirm it all checks out, both starting from scratch on a new cluster and editing an existing.

thanks for submission and helping keep us up to date!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2019
@geojaz
Copy link
Member

geojaz commented Dec 8, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geojaz, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit f4320a8 into kubernetes:master Dec 8, 2019
@olemarkus olemarkus deleted the bump-cilium-11 branch December 8, 2019 12:48
This was referenced Dec 8, 2019
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2019
@k8s-ci-robot
Merge pull request #8071 from olemarkus/automated-cherry-pick-of-#802…
6e47d81 
…2-origin-release-1.17

Automated cherry pick of #8022: Bump cilium version to 1.6.4
k8s-ci-robot added a commit that referenced this pull request Dec 28, 2019
@k8s-ci-robot
Merge pull request #8059 from olemarkus/automated-cherry-pick-of-#802…
eb50e5e 
…2-origin-release-1.15

Automated cherry pick of #8022: Bump cilium version to 1.6.4
k8s-ci-robot added a commit that referenced this pull request Dec 28, 2019
@k8s-ci-robot
Merge pull request #8060 from olemarkus/automated-cherry-pick-of-#802…
79be155 
…2-origin-release-1.16

Automated cherry pick of #8022: Bump cilium version to 1.6.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geojaz geojaz Awaiting requested review from geojaz

@granular-ryanbonham granular-ryanbonham Awaiting requested review from granular-ryanbonham

Assignees

@geojaz geojaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olemarkus @k8s-ci-robot @zetaab @geojaz