Run goimports in make ci

[tioxy]

What type of PR is this?
/kind bug

What this PR does / why we need it:
When running make ci, assures that autogenerated files are properly indented when developing locally. It also fixes the scenario where upup/models/bindata.go is generated locally, not indented, and breaks the verify-goimports test.

Which issue(s) this PR fixes:
NONE

Special notes for your reviewer:
The discussion started here: #7865 (comment)

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @tioxy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tioxy]

cc @geojaz

[tioxy]

/assign @chrislovecnm

[chrisz100]

/ok-to-test

[geojaz]

/lgtm
thanks :)

[geojaz]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geojaz, tioxy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [geojaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[johngmyers]

This change introduces a new bug.

If the current commit contains a file with an import formatting error, such that make verify-goimports would fail, then a make ci will give the wrong error message, giving the user the wrong instructions for fixing the problem.

The added goimports will "fix up" the problem, causing the later verify-goimports to incorrectly pass. Then, verify-gomod will notice the dirty workspace and incorrectly tell the user to run go mod tidy.

[tioxy]

@johngmyers What I think would solve this is removing the goimports from make ci, and then adding the following command to this alias:

goimports -w -v $(BINDATA_TARGETS)

or maybe directly

goimports -w -v upup/models/bindata.go

What do you think about it?

[johngmyers]

@tioxy That seems a reasonable approach. The other would be to fix go-bindata to format things properly, but that seems a bit time-consuming.