-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alicloud: use Balance as MultiAZPolicy #8030
Conversation
Hi @bittopaz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@bittopaz please check that alicloud should work after these merged prs. I do not have possibility to verify that
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bittopaz, zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zetaab sure, I will verify it. Thank you for your help. |
This is part of #4127.
This is just a small change, but involves vendor upgrade.
By default, the new instances will first scale in the first subnet, only when there is not enough resources in that subnet(AZ), it will then scale new instances to another subnet.
By setting MultiAZPolicy to Balance, all the scaled instances in the scaling group will spread across all the subnets equally, which is much better for reliability.
MultiAZPolicy is only supported in the latest Alicloud SDK, so I also upgrade the SDK to latest version.