Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alicloud: use Balance as MultiAZPolicy #8030

Merged
merged 3 commits into from
Dec 3, 2019
Merged

Alicloud: use Balance as MultiAZPolicy #8030

merged 3 commits into from
Dec 3, 2019

Conversation

bittopaz
Copy link
Contributor

@bittopaz bittopaz commented Nov 28, 2019

This is part of #4127.

This is just a small change, but involves vendor upgrade.

By default, the new instances will first scale in the first subnet, only when there is not enough resources in that subnet(AZ), it will then scale new instances to another subnet.

By setting MultiAZPolicy to Balance, all the scaled instances in the scaling group will spread across all the subnets equally, which is much better for reliability.

MultiAZPolicy is only supported in the latest Alicloud SDK, so I also upgrade the SDK to latest version.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @bittopaz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2019
@bittopaz bittopaz mentioned this pull request Nov 28, 2019
@zetaab
Copy link
Member

zetaab commented Nov 28, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2019
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@bittopaz please check that alicloud should work after these merged prs. I do not have possibility to verify that

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bittopaz, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit c60a0e0 into kubernetes:master Dec 3, 2019
@bittopaz
Copy link
Contributor Author

bittopaz commented Dec 3, 2019

@zetaab sure, I will verify it.

Thank you for your help.

@bittopaz bittopaz deleted the ali-patch-11 branch December 4, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants