Fix Handling of LaunchTemplate Versions for MixedInstancePolicy

[granular-ryanbonham]

Correctly detect the version of the LaunchTemplate that should be used, handling Default, Latest, and a specified version..

Currently if you are using TF output and using mixed instances policies for your IGs, without this patch in 1.14+ the rolling update always thinks nodes need to be rolled.

TF issue caused by this PR which was to fix handling of ASG set to use default version of the Launch Template.#7445

TF is settings specific version, and not changing the default, so the logic in 7445 broke rolling updates for TF generated ASGs.

Recommend CP to 1.14, 1.15, 1.16 with new releases.

[granular-ryanbonham]

/test pull-kops-verify-gomod

[johngmyers]

Not to block the PR, but is there any way we could write a test for this sort of thing? It'd probably have to be a new suite, as it's not end-to-end but it needs to run on AWS infrastructure.

I think a suite that verifies that a fi.Cloud implementation behaves according to contract would be quite useful.

[granular-ryanbonham]

Agreed we need to improve testing in this area, i didn't have time to address that, and needed to get a patch out as this was impacting our upgrades. I will see if i can find some time to work on testing in this area, but would like to do that separate from this PR.

[granular-ryanbonham]

Related to previous PR: #7445

[mikesplain]

Ahh yeah, good fix @granular-ryanbonham! Lets definitely plan to CP to 1.15 and 1.16. I'm not sure 1.14 is worth it since we should be pushing people to 1.15 and beyond. I don't feel that strongly though so up to you 😉 .

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: granular-ryanbonham, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [granular-ryanbonham,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[paalkr]

Will this get into the next 1.16 release?