fix 404 urls #8052
fix 404 urls #8052
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/assign @rifelpet |
docs/development/api_updates.md
Outdated
| @@ -3,7 +3,7 @@ | |||
| Kops uses the Kubernetes API machinery. It is well designed, and very powerful, but you have to | |||
| jump through some hoops to use it. | |||
|
|
|||
| Recommended reading: [kubernetes API changes doc](https://github.com/kubernetes/community/blob/master/contributors/devel/api_changes.md) | |||
| Recommended reading: [kubernetes API convention doc](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md) | |||
There was a problem hiding this comment.
The api_changes.md still exists under sig-architecture as well:
I think both are useful to understand, so maybe we include both links?
There was a problem hiding this comment.
You're right. I will add both links.
yuxiaobo96
force-pushed
the
kops-links
branch
from
eac0c0e
to
d13bba8
Compare
|
@rifelpet |
| @@ -196,7 +196,7 @@ If you don't want KOPS to auto-select the instance type, you can use the followi | |||
|
|
|||
| But, before doing that, always ensure the instance types are available on your desired AZ. | |||
|
|
|||
| NOTE: More arguments and kops commands are described on the following document: [commands.md](https://github.com/kubernetes/kops/blob/master/docs/commands.md) | |||
| NOTE: More arguments and kops commands are described on the following document: [cli](https://github.com/kubernetes/kops/tree/master/docs/cli) | |||
There was a problem hiding this comment.
One more thing, perhaps we can use a relative path here? that way it would work with both reading the markdown files on github as well as the docs site
| NOTE: More arguments and kops commands are described on the following document: [cli](https://github.com/kubernetes/kops/tree/master/docs/cli) | |
| NOTE: More arguments and kops commands are described [here](../cli/kops.md). |
There was a problem hiding this comment.
@rifelpet agree
@yuxiaobo96 update it?Thanks
|
@rifelpet @tanjunchen |
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
yuxiaobo96
force-pushed
the
kops-links
branch
from
c7a1fce
to
7cf24a5
Compare
|
Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet, yuxiaobo96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kops-e2e-kubernetes-aws |
Signed-off-by: yuxiaobo yuxiaobogo@163.com
ref: #7944
Because some of the linked files changed a lot, I just modified them as I thought.
Therefore, some links in this pr may be modified incorrectly.