Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to kubernetes 1.16 #8055

Merged
merged 9 commits into from
Jan 17, 2020
Merged

Update dependencies to kubernetes 1.16 #8055

merged 9 commits into from
Jan 17, 2020

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Dec 7, 2019

Helps pare down our dependency on kubernetes/kubernetes

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2019
@justinsb justinsb force-pushed the remove_kubernetes branch 4 times, most recently from 86a8832 to d8802c1 Compare December 9, 2019 04:36
@justinsb justinsb changed the title WIP: Move kubectl dependency to k8s.io/kubectl WIP: Update dependencies to kubernetes 1.16 Dec 9, 2019
@justinsb justinsb mentioned this pull request Dec 9, 2019
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2020
@justinsb justinsb mentioned this pull request Jan 11, 2020
Closed
@justinsb
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

Looks like a flake

rifelpet
rifelpet reviewed Jan 12, 2020
View reviewed changes
dns-controller/cmd/dns-controller/main.go Outdated
@@ -32,7 +32,8 @@ import (

"k8s.io/client-go/kubernetes"
"k8s.io/client-go/rest"
_ "k8s.io/kubernetes/pkg/client/metrics/prometheus" // for client metric registration

// _ "k8s.io/kubernetes/pkg/client/metrics/prometheus" // for client metric registration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tracked down the PR that moved this package

https://github.com/kubernetes/kubernetes/pull/81432/files#diff-a9f93108ac59ff44885fc0aea2f29e71R29

and it looks like this can be updated to k8s.io/component-base/metrics/prometheus/restclient

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - great find! Replaced with that new location

@justinsb justinsb force-pushed the remove_kubernetes branch 2 times, most recently from 4d3e5ed to 4c5efd9 Compare January 12, 2020 17:00
@rifelpet
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

2 similar comments
@rifelpet
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member

for whenever you're ready to remove WIP
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2020
@justinsb justinsb changed the title WIP: Update dependencies to kubernetes 1.16 Update dependencies to kubernetes 1.16 Jan 17, 2020
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 17, 2020
@rifelpet
Copy link
Member

/retest

Strange that we're getting image not found errors, I'd expect the version markers that we use to indicate that the images have been pushed already.

E0117 12:05:49.948135   13691 remote_image.go:113] PullImage "k8s.gcr.io/kube-scheduler-amd64:v1.18.0-alpha.1.852_05b6c32886cf52" from image service failed: rpc error: code = Unknown desc = Error response from daemon: manifest for k8s.gcr.io/kube-scheduler-amd64:v1.18.0-alpha.1.852_05b6c32886cf52 not found: manifest unknown: Failed to fetch "v1.18.0-alpha.1.852_05b6c32886cf52" from request "/v2/kube-scheduler-amd64/manifests/v1.18.0-alpha.1.852_05b6c32886cf52".

@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f04966a into kubernetes:master Jan 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

@justinsb: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 5ebbfc9 link /test pull-kops-e2e-kubernetes-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rifelpet rifelpet mentioned this pull request Feb 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinsb @rifelpet @k8s-ci-robot