-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mounting Calico "flexvol-driver-host" in CoreOS #8062
Conversation
Hi @hakman. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @granular-ryanbonham |
@hakman thank you for the contribution. LGTM, had to do something similar for the Canal manifest update. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, KashifSaadat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @KashifSaadat. This was the reason I asked for your review. I hope that the extra auto-detection bits will help. |
Sure definitely worth cherry-picking. If you're able to raise PRs for the |
Thanks @KashifSaadat. I created #8066, #8067 and #8068 for cherry-picking. |
Cherry pick of #8062 to release-1.17
Cherry pick of #8062 to release-1.15
Cherry pick of #8062 to release-1.16
Calico has been broken in CoreOS since 1.15, as discussed in #7592, #7931 and in #kops-users.
There is a simple workaround, but still annoying for inexperienced users:
https://docs.projectcalico.org/v3.9/reference/faq#are-the-calico-manifests-compatible-with-coreos
To fix this I am passing the kubelet volume for external plugins as parameter to the template, same way it's done for Canal:
kops/upup/models/cloudup/resources/addons/networking.projectcalico.org.canal/k8s-1.15.yaml.template
Line 701 in ebbebc5
To make things easier I also added a naive approach of detecting the distro based on image location like
595879546273/CoreOS-stable-2303.3.0-hvm
. This should make it easier to get started for those that use the image location instead of ID when creating a new cluster./cc @zetaab