Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NFT with Calico and Canal #8076

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 10, 2019

Newer distros like Debian 10 and RHEL/CentOS 8 are using iptables 1.8 which defaults to NFT backend. Kubernetes 1.17 adds support and auto-detection for it. From the release notes:

The official kube-proxy image (used by kubeadm, among other things) is now compatible with systems running iptables 1.8 in “nft” mode, and will autodetect which mode it should use. (#82966)

Calico doesn't yet have auto-detection for the iptables backend, but has a flag named IptablesBackend (env var FELIX_IPTABLESBACKEND) that can switch from Legacy to NFT:
https://docs.projectcalico.org/v3.9/reference/felix/configuration#iptables-dataplane-configuration

Without this flag Debian 10 networking is broken in Kubernetes 1.17.0. Kubernetes auto-detects NFT and uses it, but Calico still uses legacy, which is an unsupported behaviour.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @hakman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 10, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2019
@hakman
Copy link
Member Author

hakman commented Dec 10, 2019

/cc @KashifSaadat
/cc @zetaab

@KashifSaadat
Copy link
Contributor

Thanks @hakman !

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 10, 2019
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, KashifSaadat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@KashifSaadat
Copy link
Contributor

KashifSaadat commented Dec 10, 2019

If you can run make crds it should sort out the test failures.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2019
@KashifSaadat
Copy link
Contributor

Perfect, thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2019
@hakman
Copy link
Member Author

hakman commented Dec 10, 2019

Thanks @KashifSaadat. Will cherry-pick also to 1.17 later today.

@k8s-ci-robot k8s-ci-robot merged commit c36470f into kubernetes:master Dec 10, 2019
k8s-ci-robot added a commit that referenced this pull request Dec 12, 2019
@hakman hakman deleted the iptables-backend branch December 27, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants