Spotinst: Upgrade the Spotinst controller to version 1.0.50

[liranp]

This PR replaces PRs #8019 and #7920, upgrades the Spotinst controller to version 1.0.50 and aligns all resources with the corresponding Helm chart.

[k8s-ci-robot]

Hi @liranp. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rifelpet]

/ok-to-test

[rifelpet]

The labels have changed from k8s-addon to k8s-app. Normally this is fine except a Deployment's label selector field is immutable, so anyone running the old manifest wouldnt be able to upgrade to the new manifest:

kops/upup/models/cloudup/resources/addons/spotinst-kubernetes-cluster-controller.addons.k8s.io/v1.9.0.yaml.template

Lines 93 to 95 in 252a733

	selector:
	matchLabels:
	k8s-addon: spotinst-kubernetes-cluster-controller.addons.k8s.io

https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#label-selector-updates

I'm wondering if the easiest solution is to just update all the k8s-app references to k8s-addon. Thoughts?

[liranp]

You're right. I've fixed that.

[rifelpet]

The diff between the two files looks much better. I noticed the new manifest is no longer defining a service account which made me realize that Kops is probably not pruning resources no longer defined in new manifests, so we will have orphaned resources out there, but I'll file an issue for that separately.

Thanks for getting this updated!
/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liranp, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@liranp: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kops-e2e-kubernetes-aws	0c1d220	link	/test pull-kops-e2e-kubernetes-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.