Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform GCE output: specify minimum GCE provider version #8106

Closed
wants to merge 1 commit into from

Conversation

justinsb
Copy link
Member

There were some incompatible changes made in version 3 of the GCE
provider, so we specify a minimum version to make version mismatches
more obvious.

As suggested in #8103

There were some incompatible changes made in version 3 of the GCE
provider, so we specify a minimum version to make version mismatches
more obvious.

As suggested in kubernetes#8103
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2019
@k8s-ci-robot
Copy link
Contributor

@justinsb: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-verify-gofmt 588dce2 link /test pull-kops-verify-gofmt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mccare
Copy link
Contributor

mccare commented Dec 14, 2019

This is incompatible with terraform 0.11 it seems. For terraform 0.11 you need to put the version into the provider block. terraform 0.12upgrade did complain.

@rifelpet
Copy link
Member

Agreed. I spoke with a hashicorp dev about this and they mentioned that long-term they are moving towards required_providers in the terraform block, but that its only supported in teraform >=0.12. This means we can't use it yet until after our 0.12 support lands.

@rifelpet
Copy link
Member

this is no longer needed so im going to close it out
/close

@k8s-ci-robot
Copy link
Contributor

@rifelpet: Closed this PR.

In response to this:

this is no longer needed so im going to close it out
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2019
@k8s-ci-robot
Copy link
Contributor

@justinsb: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants