Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubeconfig flag to validate cluster command #8110

Merged

Conversation

vvbogdanov87
Copy link
Contributor

Fixes #7559

Signed-off-by: vvbogdanov87 <vvbogdanov87@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @vvbogdanov87. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 15, 2019
@johngmyers
Copy link
Member

Looks like you need to make gen-cli-docs

@vvbogdanov87
Copy link
Contributor Author

@johngmyers I used bazel to build kops. When I run make gen-cli-docs I get

upup/models/vfs.go:71:15: undefined: Asset
upup/models/vfs.go:82:16: undefined: AssetDir
upup/models/vfs.go:107:16: undefined: AssetDir

Looks like bindata.go is missing under upup/models. Can't find information where to get it. Can I just copy the file from k8s.io/kops? Could you please assist.

@johngmyers
Copy link
Member

make upup/models/bindata.go will generate it.

@johngmyers
Copy link
Member

I can't reproduce against master your problem. If I remove upup/models/bindata.go, then make gen-cli-docs regenerates it.

@joshbranham
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 16, 2019
@vvbogdanov87
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@justinsb
Copy link
Member

Thanks @vvbogdanov87 - this looks good.

FYI you can always pass the env var KUBECONFIG, but we should support kubeconfig here explicitly!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, vvbogdanov87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit db11481 into kubernetes:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --kubeconfig option to kops cluster validate
5 participants