Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kops-change-main #8132

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Conversation

zehuaiWANG
Copy link
Contributor

@zehuaiWANG zehuaiWANG commented Dec 17, 2019

I do some cleanup in main file and model/utils.go, to make code more cleaner.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @zehuaiWANG. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2019
@zehuaiWANG
Copy link
Contributor Author

zehuaiWANG commented Dec 17, 2019

/assign @tanjunchen Could you help me to have a look and add /ok-to-test label?

@hwdef
Copy link
Member

hwdef commented Dec 17, 2019

please update the PR introduction,
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2019
@zehuaiWANG
Copy link
Contributor Author

/assign @rifelpet

@tanjunchen
Copy link
Member

please update the PR introduction,
/ok-to-test

Agree +1
@zehuaiWANG An obvious title is better , not "a liitle change"
/cc @rifelpet @justinsb

@zehuaiWANG
Copy link
Contributor Author

@tanjunchen I add more description to the pr, it's a liitle clean up job.

@tanjunchen
Copy link
Member

ok. Thanks

@rifelpet
Copy link
Member

Having all the variables defined together and all the flags defined together does make it easier to read. thanks for the contribution!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, zehuaiWANG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 015efe0 into kubernetes:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants