GCE: Fix Permission for the Storage Bucket

[mccare]

Needs to be Role:Entity Name not Role:Resource Name. It came out as
WRITER:serviceAccount...
now it is
WRITER:user-708930735790-compute@developer.gserviceaccount.com

https://cloud.google.com/storage/docs/json_api/v1/bucketAccessControls

[k8s-ci-robot]

Hi @mccare. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rifelpet]

/ok-to-test

[geojaz]

/lgtm

[geojaz]

i think this is 👍 and it looks like it takes care of one of the issues that i've seen. however, we're not running gce e2e tests (yet!). i just kicked off a run over here to take a look and i'll report back. thanks for looking into this :D

[rifelpet]

I would expect the integration tests to fail any idea why they didnt? It'd be great if we could get this added into the integration tests too.

[mccare]

The permissions are only set if there is a gce bucket as configBase. In test setup, the storageacl finds memfs:// and cannot apply the IAM policy:

W1219 18:11:09.172186   63889 storageacl.go:101] unknown path, can't apply IAM policy: "memfs://tests/ha-gce.example.com/backups/etcd/main"
W1219 18:11:09.172192   63889 storageacl.go:101] unknown path, can't apply IAM policy: "memfs://tests/ha-gce.example.com/backups/etcd/events"

[geojaz]

/approve

[geojaz]

/approve cancel

[geojaz]

/lgtm

[geojaz]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geojaz, mccare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [geojaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment