-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run dns-controller and kops-controller as non-root user #8169
Run dns-controller and kops-controller as non-root user #8169
Conversation
Hi @johngmyers. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@@ -21,4 +21,6 @@ RUN apt-get update && apt-get install --yes ca-certificates \ | |||
|
|||
COPY /.build/artifacts/dns-controller /usr/bin/dns-controller | |||
|
|||
USER 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own understanding, do we need to also set the user in the securityContext
of the dns-controller
here: https://github.com/kubernetes/kops/blob/master/upup/pkg/fi/cloudup/tests/bootstrapchannelbuilder/simple/dns-controller.addons.k8s.io-k8s-1.12.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will in order to pass admission controllers that check for this sort of thing, but we need someone to release new images built from this Dockerfile
first. So that's a different PR.
c7df214
to
14bc441
Compare
/test pull-kops-verify-boilerplate |
/test pull-kops-e2e-kubernetes-aws |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
They do not need root privileges, so should not be given them.