-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerd: Add --container-runtime cli flag #8172
containerd: Add --container-runtime cli flag #8172
Conversation
Hi @hakman. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @justinsb |
9c11553
to
8d56f0e
Compare
/ok-to-test |
/test pull-kops-e2e-kubernetes-aws |
8d56f0e
to
906a0ac
Compare
906a0ac
to
558768b
Compare
94e81ac
to
8523dd8
Compare
/test pull-kops-verify-staticcheck |
Thanks @hakman - looks great! I agree we should make the value explicit in the cluster, as we transition people from docker -> containerd. (It's also best practice for union fields: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190325-unions.md#discriminator ) /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is related to #7986.